Vince what is your opinion ...
If we want to replace a knob or button on our vintage instrument, does the button need to look brand new, or does it need to look like other buttons that are "weathered" (model RR term) and used? Which is the perfect choice in your opinion?
Oh boy I am sorry to realize that I am seen as being so anal and extremist ?!
... because I am really not, I have no dogma or religion about restoring old stuff, I don't know where people got that idea !
I understand that some people are, just like there are audiophools, there are resto-phools !
I am not one of them at all !
My old glowing Tek scopes are the only reason I am getting interested in restoring old TE, because I like them very much, find them beautiful so am trying to find ways to fix them cosmetically as best as reasonably possible... that is all. If something is too broken to be fixed well so be it, what can I do about it , I will have to live with it
... but if something CAN possibly made better, short of being perfect, then yes hell I will put some thoughts and effort into it to see if that leads me somewhere worthwhile !
Like redoing the leather carry handles for example, or doing some metal work to straighten bent/damaged chassis/ frames and covers, or repainting covers, or sand blasting this or that, polishing this or that, buying new screws with funny imperial units... every thing that's not crazy expensive and does not require 40 years of experience to get a half decent result... I am willing to try !
So now that I have me covered, let's reply to your question !
In short : I have no religion on the matter... I would do whatever appears to find my fancy for that particular project ! Sometimes it might be easier to make brand new looking XYZ, so makes sense to redo all the knobs so as to get a consistent look, if that's not too much work, as in 6 months full time work...
But if you are happy with the patina of the existing buttons and your reproduction button is close enough to that patina to not look out of place... well then patina it is then !
Really every particular project is unique, there is no 11th commandment about that I think ! Just do whatever you feel makes most sense to YOU !