why wont this compole?

[m3vuv]

Hi all,im trying to get this on to an arduino uno,it comes up with an error msg saying"expected unqualified-id before  '(' token heres the sketch:
/*

http://www.bristolwatch.com/radio/arduino_coil_winder.htm
Arduino Stepper Motor Coil Winder
Lewis Loflin
lewis@bvu.net

*/



#define yellow 9  //Q1
#define orange 10  //Q2
#define brown 11  // Q3
#define black 12 // Q4

#define SW0 2
#define SW1 3
#define SW2 4
#define SW3 5

#include <OneWire.h>
#include <Wire.h>
#include <LiquidCrystal_I2C.h>
LiquidCrystal_I2C lcd(0x27, 16, 2);
// set the LCD address to 0x27

int i, j;

void setup()  {

  pinMode(SW0, INPUT);
  pinMode(SW1, INPUT);
  pinMode(SW2, INPUT);
  pinMode(SW3, INPUT);

  digitalWrite(SW0, 1); // pull up on
  digitalWrite(SW1, 1); // pull up on
  digitalWrite(SW2, 1);
  digitalWrite(SW3, 1);

  lcd.init(); // initialize the lcd
  lcd.backlight();

  pinMode(black, OUTPUT);
  pinMode(brown, OUTPUT);
  pinMode(orange, OUTPUT);
  pinMode(yellow, OUTPUT);
  all_coils_off();

  lcd.clear();
  lcd.home();
  lcd.print("Wait 2 sec.");

  delay(2000); // wait for 2 seconds
  lcd.setCursor(0, 1); // is Home
  lcd.print("Ready to go!");

  j = 0;

}

void loop() {

  // set turns
  if (!digitalRead(SW0) == 1)   {
    delay(1000);
    j = 0;
    lcd.clear();
    lcd.home();
    lcd.print("Turns = 0  ");
    while (!digitalRead(SW0) == 1)   {
      delay(1000);
      if (!digitalRead(SW1) == 1) j = j + 1;
      if (!digitalRead(SW2) == 1) j = j + 10;
      lcd.setCursor(8, 0);
      lcd.print(j);
    } // end while
    lcd.setCursor(0, 1);
    lcd.print("Ready to wind.");
  }

  if (!digitalRead(SW3))  {
    lcd.clear();
    lcd.home();
    lcd.print("Turns 0  ");
    for (i = 1; i <= j; i++)   {
      reverse(200);
      lcd.setCursor(6, 0);
      lcd.print(i);
    }
    all_coils_off();
    lcd.setCursor(0, 1);
    lcd.print("Finished ");
  }

} // end loop


void all_coils_off(void)  {
  digitalWrite(black, 0);
  digitalWrite(brown, 0);
  digitalWrite(orange, 0);
  digitalWrite(yellow, 0);

}

void reverse(int i) {
  while (1)   {
    digitalWrite(black, 1);
    digitalWrite(brown, 0);
    digitalWrite(orange, 0);
    digitalWrite(yellow, 1);
    delay(analogRead(0) / 4 + 5);
    i--;
    if (i < 1) break;

    digitalWrite(black, 0);
    digitalWrite(brown, 1);
    digitalWrite(orange, 0);
    digitalWrite(yellow, 1);
    delay(analogRead(0) / 4 + 5);
    i--;
    if (i < 1) break;

    digitalWrite(black, 0);
    digitalWrite(brown, 1);
    digitalWrite(orange, 1);
    digitalWrite(yellow, 0);
    delay(analogRead(0) / 4 + 5);
    i--;
    if (i < 1) break;

    digitalWrite(black, 1);
    digitalWrite(brown, 0);
    digitalWrite(orange, 1);
    digitalWrite(yellow, 0);
    delay(analogRead(0) / 4 + 5);
    i--;
    if (i < 1) break;
  }
}
any idear what im doing wrong?,cheers Paul.

[sokoloff]

I just copied your code into my environment and it compiles fine as-is.

Arduino 1.8.10 on MacOS.

I had to install two libraries:
OneWire - v2.3.5 by Jim Studt and a long list of other people
LiquidCrystal_I2C - v1.1.12 by Frank de Brabander

[donotdespisethesnake]

@sokoloff beat me to it, but compiles fine here on Arduino 1.8.3 with the additional libraries installed.

[Andy Watson]

Did you copy and paste the code from a web-page? If so, and considering the above two replies, there might be a non-printing ascci character embeded in the code.

[m3vuv]

well yes i coppied it direct from a web page,ive already got the librarys installed,any ideas on the error msg i got?

[donotdespisethesnake]

If you copy and paste all the output from the compiler window, someone might be able to help.

[m3vuv]

well i downloaded the same librarys and ide version as sokaloff used to compile it,this is what i get,see attached screenshot.

[m3vuv]

heres a copy of the message i get,by the lack of replies i take it no one knows the issue!?
Arduino: 1.8.3 (Windows 7), Board: "Arduino/Genuino Uno"

C:\Users\me\Documents\Arduino\sketch_nov03a\sketch_nov03a.ino: In function 'void reverse(int)':

sketch_nov03a:133: error: expected primary-expression before ')' token

     if (i < 1) break;)

                      ^

sketch_nov03a:133: error: expected '}' at end of input

sketch_nov03a:133: error: expected '}' at end of input

exit status 1
expected primary-expression before ')' token

This report would have more information with
"Show verbose output during compilation"
option enabled in File -> Preferences.

[Mr. Scram]

It says what's wrong right in that error message. What you're trying to compile likely isn't what you posted here. Your local copy probably says "if (i < 1) break;)" instead of"if (i < 1) break;" Your ifs may need additional brackets too. I'm normally not one to point out spelling errors in thread titles but it's exactly those kinds of mistakes that gets you into trouble when writing code. Be careful and deliberate as a single character can screw you over. Also take heed of error messages as they tell you what's wrong or at least point you in the right direction.

[Andy Watson]

sketch_nov03a:133: error: expected primary-expression before ')' token

     if (i < 1) break;)

                      ^

sketch_nov03a:133: error: expected '}' at end of input

133 is telling you the line number at which the compiler borks. In this case it appears to be the line after an "if ... break;" statement. For some reason there is a superfluous right-bracket at the end of the line.

[StillTrying]

Who'd have guessed it would've turned out to be a typo.

[m3vuv]

Strange but i copied and pasted it againe into the ide and it compiled and uploaded fine?,not sure why but who cares,job done,cheers m3vuv.

[Mr. Scram]

Strange but i copied and pasted it againe into the ide and it compiled and uploaded fine?,not sure why but who cares,job done,cheers m3vuv.

Why would that be unexpected? We told you what was wrong with your original code. You must have manually introduced the error we indicated. Now that you copied the code without that error it compiles correctly. Be sure to carefully assess what you're doing and make sure to take care of the details. Judging by this reply I fear you haven't learned from your mistake.

[m3vuv]

Finaly found the root cause of the issue,it was due to having 2 arduino tabs open!,may help others as im sure im not the onlyone had this problem,sometimes the answers so simple ppl miss it !!!

[Mr. Scram]

Finaly found the root cause of the issue,it was due to having 2 arduino tabs open!,may help others as im sure im not the onlyone had this problem,sometimes the answers so simple ppl miss it !!!

That's not what your compiler said. Why bother asking questions only to ignore the answers?

[maginnovision]

Finaly found the root cause of the issue,it was due to having 2 arduino tabs open!,may help others as im sure im not the onlyone had this problem,sometimes the answers so simple ppl miss it !!!

That's not what your compiler said. Why bother asking questions only to ignore the answers?

I think it's actually his new hobby. Ask questions, demand prompt replies, then ignore everyone and say, "Nevermind! I figured it out myself!".

[SiliconWizard]

Finaly found the root cause of the issue,it was due to having 2 arduino tabs open!,may help others as im sure im not the onlyone had this problem,sometimes the answers so simple ppl miss it !!!

That's not what your compiler said.

You must mean, "compoler"?